Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumping out of a dropship heading towards an LZ now throws your body at the ground, instead of deleting it. #5584

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

Contrabang
Copy link
Contributor

@Contrabang Contrabang commented Jan 29, 2024

About the pull request

Jumping out of a dropship heading towards an LZ now throws your body at the ground, instead of deleting it. This does around 500 damage, and permanently kills you.

image

These people falling out of the sky, can land anywhere where there is no ceiling (or a glass one). Basically anywhere you can mortar, medevac, or laze something.

This only works if the dropship is heading towards one of the LZs, if not, then they're deleted like normal.

I also fixed the throwing, so it doesn't appear like you're just standing in space for 0.5 seconds before being disappeared.

I also removed some unused arguments in take_overall_damage and take_overall_armored_damage.

Explain why it's good for the game

It adds a bit of depth to the game, instead of your character being just outright deleted, their body actually ends up somewhere.

Testing Photographs and Procedure

Screenshots & Videos
dreamseeker_d7hgE37wov.mp4

(It does play sounds when you land, you just cant really hear them in this clip because they died.)

image

image

dreamseeker_Prr22NcUq7.mp4

(Items do a little bounce when they land too)

Changelog

🆑
add: Falling out of a Dropship en route to an LZ, now lets your corpse plummet to the ground instead of being deleted.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jan 29, 2024
@Contrabang Contrabang marked this pull request as draft January 29, 2024 00:44
@Contrabang Contrabang marked this pull request as ready for review January 29, 2024 04:20
Co-authored-by: private-tristan <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 7, 2024
@Birdtalon Birdtalon removed the Stale beg a maintainer to review your PR label Feb 10, 2024
cm13-github added a commit that referenced this pull request Feb 12, 2024
@ekcja1 ekcja1 mentioned this pull request Feb 12, 2024
3 tasks
cm13-github added a commit that referenced this pull request Feb 13, 2024
cm13-github added a commit that referenced this pull request Feb 13, 2024
@Crimsonerva Crimsonerva mentioned this pull request Feb 13, 2024
3 tasks
@FighterOfKeyboard FighterOfKeyboard mentioned this pull request Feb 13, 2024
3 tasks
cm13-github added a commit that referenced this pull request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 15, 2024
cm13-github added a commit that referenced this pull request Feb 15, 2024
cm13-github added a commit that referenced this pull request Feb 15, 2024
@GamerRed13 GamerRed13 mentioned this pull request Feb 16, 2024
3 tasks
cm13-github added a commit that referenced this pull request Feb 18, 2024
cm13-github added a commit that referenced this pull request Feb 18, 2024
cm13-github added a commit that referenced this pull request Feb 19, 2024
@Birdtalon Birdtalon added this pull request to the merge queue Feb 20, 2024
Merged via the queue into cmss13-devs:master with commit f9ed344 Feb 20, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 20, 2024
@Contrabang Contrabang deleted the orbital-drop-shock-troopers branch February 21, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants